WIP Use OpenShift console timestamp component #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinFCormier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@KevinFCormier, thanks for making the changes, these look good to me |
|
@KevinFCormier, please let me know what you think of the to-dos implementation |
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
Signed-off-by: Kevin Cormier <[email protected]>
KevinFCormier
force-pushed
the
use-ocp-timestamp-component
branch
from
fe49550 to
051b000
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
<Timestamp />component from OpenShift console available and simplifies the current mechanism for using console dynamic plugin SDK hooks and components while maintaining the ability to run in standalone mode.The
<Timestamp />component gives us an easy way to have consistent display of timestamps that are localized.Placeholder for standalone dev mode:
Demonstrating translated date/time string (French) and tooltip, with icon removed:
Relative time display (once the current bug is implemented):
TODOs: